internal/dag: Watch namespaces from k8s api #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
added
the
release-note-action-required
stevesloka
requested review from
danehans and
skriss
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
+ Coverage 75.24% 75.25% +0.01%
==========================================
Files 98 98
Lines 6531 6546 +15
==========================================
+ Hits 4914 4926 +12
- Misses 1509 1512 +3
Partials 108 108
|
|
I think informer caches would make this much simpler, but thought we could add that later. This would let us use internal label queries and not loop over the internal caches, but think it's a good spot for a tech debt update if someone wanted to pick it up. // #2683 |
skriss
requested changes
Feb 26, 2021
youngnick
approved these changes
Mar 1, 2021
The RouteBindingSelector in Gateway API has an option to only process routes which exist in a namespace based upon a selector defined in the Gateway. Updates projectcontour#3401 Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
watchNamespaces
branch
from
273c7a8
to
b58e891
Compare
skriss
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RouteBindingSelector in Gateway API has an option to only process routes which exist
in a namespace based upon a selector defined in the Gateway.
When "Selector" is chosen then only Routes in namespaces selected by the selector may be used by this Gateway (https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.RouteSelectType).
Added release note action label since this updates RBAC permissions, but only needed if Gateway APIs are present.
Updates #3401
Signed-off-by: Steve Sloka slokas@vmware.com