-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Exact HTTPHeaderMatch #3538
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
+ Coverage 76.23% 76.27% +0.03%
==========================================
Files 100 100
Lines 6892 6903 +11
==========================================
+ Hits 5254 5265 +11
Misses 1521 1521
Partials 117 117
|
var services []*Service | ||
|
||
for _, match := range rule.Matches { | ||
mc := &matchConditions{} | ||
switch match.Path.Type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need a nil
check on the Path
field as well, since it can be omitted
probably should add a test that adds a header match but no path match (which should result in a default /
prefix match) to ensure this is covered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added match.Path.Value == "" || match.Path.Type == ""
check since match.Path
was changed to pointer recently by kubernetes-sigs/gateway-api@9d63656 (not included in current gateway-api release) so we need to change it to nilt check when gateway-api lib is updated.
This patch adds Exact HTTPHeaderMatch. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
This patch adds Exact HTTPHeaderMatch support.
Fixes #3356
Signed-off-by: Kenjiro Nakayama nakayamakenjiro@gmail.com
/cc @stevesloka @youngnick @sunjayBhatia