Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updates to getting started guide #4288

Merged
merged 7 commits into from
Jan 24, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Jan 21, 2022

No description provided.

@skriss skriss requested a review from a team as a code owner January 21, 2022 20:36
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team January 21, 2022 20:36
@skriss skriss force-pushed the docs-getting-started branch 2 times, most recently from 785d889 to e3f22e1 Compare January 21, 2022 20:49
@skriss
Copy link
Member Author

skriss commented Jan 21, 2022

OK, I'm pretty happy with this now in that it covers:

  • kind cluster
  • "regular" cluster with LB service support

And:

  • YAML install
  • Helm install
  • Operator install

There are unfortunately a few variations on the steps for some of the combinations, but I tried to keep it as simple as possible. Feedback welcome!

https://deploy-preview-4288--projectcontour.netlify.app/getting-started/

@skriss skriss added the release-note/docs A documentation change for the release notes. label Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #4288 (f4f7e1d) into main (cc47826) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4288      +/-   ##
==========================================
- Coverage   77.80%   77.79%   -0.01%     
==========================================
  Files         112      112              
  Lines       10026    10026              
==========================================
- Hits         7801     7800       -1     
- Misses       2043     2044       +1     
  Partials      182      182              
Impacted Files Coverage Δ
internal/sorter/sorter.go 97.57% <0.00%> (-0.61%) ⬇️

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I agree that using Kuard is not ideal, but it's been like this for ages already, so I won't block my approval on fixing it. 😄

site/content/getting-started/_index.md Outdated Show resolved Hide resolved
stevesloka and others added 5 commits January 24, 2022 15:47
Updates the getting-started and quickstart guides for installing Contour/Envoy.

Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss merged commit 0541ccc into projectcontour:main Jan 24, 2022
@skriss skriss deleted the docs-getting-started branch January 24, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants