-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further updates to getting started guide #4288
Conversation
785d889
to
e3f22e1
Compare
OK, I'm pretty happy with this now in that it covers:
And:
There are unfortunately a few variations on the steps for some of the combinations, but I tried to keep it as simple as possible. Feedback welcome! https://deploy-preview-4288--projectcontour.netlify.app/getting-started/ |
Codecov Report
@@ Coverage Diff @@
## main #4288 +/- ##
==========================================
- Coverage 77.80% 77.79% -0.01%
==========================================
Files 112 112
Lines 10026 10026
==========================================
- Hits 7801 7800 -1
- Misses 2043 2044 +1
Partials 182 182
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I agree that using Kuard is not ideal, but it's been like this for ages already, so I won't block my approval on fixing it. 😄
Updates the getting-started and quickstart guides for installing Contour/Envoy. Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
3e9360f
to
36dadd4
Compare
Signed-off-by: Steve Kriss <krisss@vmware.com>
No description provided.