Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Grafana dashboard for Contour doesn't work with lots of virtualhost #211

Closed
rosskukulinski opened this issue Aug 9, 2018 · 0 comments
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@rosskukulinski
Copy link
Contributor

What steps did you take and what happened:

I created many IngressRoute objects, each with a unique virtualhost. Viewing the Contour dashboard for valid and invalid IngressRoutes did not work (grafana put a ! icon indicating something was wrong with the graph query).

What did you expect to happen:

Grafana graphs for invalid and valid ingressroutes should work regardless of the number of virtualhosts or namespace.

Anything else you would like to add:

The issue seems to be with the Grafana variables we have, Vhost and namespace. They support Grafana's "All" value, which by default lists every possible option. This is bad for prometheus:

By default the All value will include all options in combined expression. This can become very long and can have performance problems. Many times it can be better to specify a custom all value, like a wildcard regex. To make it possible to have custom regex, globs or lucene syntax in the Custom all value option it is never escaped so you will have to think avbout what is a valid value for your data source.

We should have a custom ALL value of .* for these (and any other) variables in our dashboards that might have high cardinality.

@rosskukulinski rosskukulinski added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2018
@rosskukulinski rosskukulinski added this to the v0.3-beta.3 milestone Aug 9, 2018
@rosskukulinski rosskukulinski self-assigned this Aug 9, 2018
stevesloka added a commit that referenced this issue Aug 9, 2018
Fixes #211. Update templated variables to use regex All value
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant