This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Split Contour from Envoy pods and implement Network Policy #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbrand
reviewed
May 4, 2018
There was a problem hiding this comment.
Did some manual testing and verified:
- If one of the contour pods goes down, envoy will open up a new connection to another instance
- Prometheus is able to scrape metrics from envoy
One thing that we should keep in mind is that network policy does not prevent access to the envoy admin interface from the host network, so we might still need a solution for that.
| - port: 443 | ||
| name: https | ||
| protocol: TCP | ||
| targetPort: 8443 | ||
| selector: | ||
| app: contour |
deployment/contour/03-envoy.yaml
Outdated
| volumes: | ||
| - name: contour-config | ||
| emptyDir: {} | ||
| restartPolicy: Always |
There was a problem hiding this comment.
Should we disable automount of service account?
There was a problem hiding this comment.
The contour-config? That's setup by the initContainer.
There was a problem hiding this comment.
Sorry. Meant setting automountServiceAccountToken: false so that the default service account does not get mounted to the envoy pod, which does not need access to the API server.
There was a problem hiding this comment.
ahh I see, yup can do that
Signed-off-by: Steve Sloka <steves@heptio.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87