Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe improvements #57

Merged
merged 4 commits into from
Dec 19, 2022
Merged

Dedupe improvements #57

merged 4 commits into from
Dec 19, 2022

Conversation

Mzack9999
Copy link
Member

Description

  • Enable skip empty items by default
  • Moves empty check inline
  • Add support for slice of items [][]byte

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 16, 2022
@Mzack9999 Mzack9999 self-assigned this Dec 16, 2022
This was linked to issues Dec 16, 2022
Add support for byte slice to filekv #55
Closed
Empty filter should be inline #56
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mzack9999 Mzack9999 mentioned this pull request Dec 16, 2022
Merged
4 tasks
@Mzack9999 Mzack9999 removed the request for review from ehsandeep December 19, 2022 10:07
@Mzack9999 Mzack9999 merged commit 651606c into main Dec 19, 2022
@Mzack9999 Mzack9999 deleted the feat-dedupe-improvements branch December 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty filter should be inline Add support for byte slice to filekv
2 participants
@Mzack9999 @tarunKoyalwar