-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: Tag Standardization #7344
Patch: Tag Standardization #7344
Conversation
1f065c8
to
a144d1c
Compare
Hey @ErikOwen! Thank you so much for updating the templates and contributing to the project. The changes you made are impressive and will greatly assist with Tag Standardization. However, it's important to keep in mind that misconfiguration templates can also be exposing something and should be marked with an exposure tag. When detecting an exposed panel, sometimes it's not limited to only the login panel being exposed, there are instances where an open panel or dashboard exposes sensitive information. In the case of panel and tech, we can explicitly mark them based on the directory structure. We have even marked some vulnerability templates as CVE, even if the specific product hasn't been assigned a CVE, but rather the vulnerability itself. For example, check out this link: https://github.com/projectdiscovery/nuclei-templates/blob/main/http/vulnerabilities/other/vmware-siterecovery-log4j-rce.yaml. Let me know if you think otherwise. On another note, thanks for taking the time to fill in all the missing tags. We'll review the PR shortly. Cheers! |
Thanks for taking a look at this PR, @princechaddha. Would it make sense to revert all the changes that remove tags that do not match the directory structure, but leave in the changes that add tags to match the directory structure? |
This reverts commit 3a815a5.
@princechaddha and @ehsandeep - I have reverted all the changes that remove tags. This PR now only adds tags to templates that are missing the tag that corresponds to the directory the template is in (i.e. Sorry for the messy git history. Hopefully the commits will get squashed if this is ever merged 😅. |
Hey, @ErikOwen! The response time to this PR was longer than usual. However, the changes you made look good. Thank you for taking the time to make the changes and for contributing to the project 🍻 Also, Feel free to join the discord server and please DM me on Discord so that we can send you our swag pack as a token of appreciation. |
Template / PR Information
Template Validation
I've validated this template locally?
Additional Details (leave it blank if not applicable)
Additional References: