Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku Takeover #7604

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Heroku Takeover #7604

merged 2 commits into from
Jul 4, 2023

Conversation

mosesrenegade
Copy link

The Heroku Takeover YAML file needed to be updated to support a change in their title message. This was causing the template to fail.

Template / PR Information

  • Fixed http/takeovers/heroku-takeover.yml
  • References:

Template Validation

I've validated this template locally?

  • YES
  • NO

Additional Details (leave it blank if not applicable)

The following is a full dump for you to look through, you can see the new request/response pairs.


GET / HTTP/1.1
Host: [redacted]
User-Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2228.0 Safari/537.36
Connection: close
Accept: */*
Accept-Language: en
Accept-Encoding: gzip

[DBG] [heroku-takeover] Dumped HTTP response https://[redacted]

HTTP/1.1 404 Not Found
Content-Length: 563
Cache-Control: no-cache, no-store
Content-Type: text/html; charset=utf-8
Date: 2023-07-03 16:42:38.629764318 +0000 UTC
Server: heroku-router

<!DOCTYPE html>
<html>
  <head>
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <meta charset="utf-8">
    <title>Heroku | Application Error</title>
    <style media="screen">
      html,body,iframe {
        margin: 0;
        padding: 0;
      }
      html,body {
        height: 100%;
        overflow: hidden;
      }
      iframe {
        width: 100%;
        height: 100%;
        border: 0;
      }
    </style>
  </head>
  <body>
    <iframe src="//www.herokucdn.com/error-pages/no-such-app.html"></iframe>
  </body>
</html>

[heroku-takeover:dsl-1] [http] [high] https://[redacted]
[heroku-takeover:word-2] [http] [high] https://[redacted]

Additional References:

mosesneuvik and others added 2 commits July 3, 2023 12:44
@mosesneuvik
Heroku Takeover
75a8c56 
THe Heroku Takeover YAML file needed to be updated in order to support a change in their title message. This was causing the template
to fail.
@ritikchaddha
Update heroku-takeover.yaml
1a41da0
@ritikchaddha ritikchaddha self-assigned this Jul 4, 2023
@ritikchaddha ritikchaddha added the Done Ready to merge label Jul 4, 2023
@DhiyaneshGeek
Copy link
Member

Hi @mosesrenegade Thank you so much for updating the template and raising a PR ! 🔥

@DhiyaneshGeek DhiyaneshGeek added the good first issue Good for newcomers label Jul 4, 2023
@DhiyaneshGeek DhiyaneshGeek merged commit f8e1de2 into projectdiscovery:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhiyaneshGeek DhiyaneshGeek DhiyaneshGeek approved these changes

Assignees

@ritikchaddha ritikchaddha

Labels
Done Ready to merge good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mosesrenegade @DhiyaneshGeek @ritikchaddha @mosesneuvik