Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for unresolved variables #1089

Merged
merged 12 commits into from
Oct 9, 2021
Merged

Added check for unresolved variables #1089

merged 12 commits into from
Oct 9, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Oct 6, 2021

This PR adds variable checks to drop templates/requests when the defined variables are not resolved, this behavior is enabled as default and can be disabled for specific templates by using skip-variables-check: true

@ehsandeep ehsandeep linked an issue Oct 6, 2021 that may be closed by this pull request
Copy link
Contributor

@forgedhallpass forgedhallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two comments should be discussed/addressed first.

@Ice3man543 Ice3man543 merged commit 7de4cc9 into dev Oct 9, 2021
@Ice3man543 Ice3man543 deleted the variables-check branch October 9, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[issue] Unresolved Variables
3 participants