Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more tests and ciphersuits for SSL protocol #1685

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Added more tests and ciphersuits for SSL protocol #1685

merged 2 commits into from
Mar 9, 2022

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Mar 7, 2022 •
edited by ehsandeep
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue Mar 7, 2022 that may be closed by this pull request
Add integration tests for network SSL/TLS #1314
Closed
@Ice3man543 Ice3man543 self-assigned this Mar 7, 2022
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 7, 2022
ehsandeep
ehsandeep requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Exposing cipher suites and other available information as part of default response.
  • Matching on response instead of cipher_matched

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 8, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 March 8, 2022 15:13
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Mar 8, 2022
@ehsandeep ehsandeep merged commit 0f38f2c into dev Mar 9, 2022
@ehsandeep ehsandeep deleted the ssl-tests branch March 9, 2022 07:37
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@its0x08 its0x08 its0x08 approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for network SSL/TLS
4 participants
@Ice3man543 @ehsandeep @Mzack9999 @its0x08