Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mutex to output writing #1969

Merged
merged 1 commit into from
May 10, 2022
Merged

Added mutex to output writing #1969

merged 1 commit into from
May 10, 2022

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented May 9, 2022 •
edited by ehsandeep
Loading

Proposed changes

Closes #1907 by adding a mutex to output writer.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 self-assigned this May 9, 2022
@Ice3man543 Ice3man543 linked an issue May 9, 2022 that may be closed by this pull request
Test Fail - race-multiple #1907
Closed
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label May 9, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 May 10, 2022 12:18
@ehsandeep ehsandeep merged commit a294719 into dev May 10, 2022
@ehsandeep ehsandeep deleted the output-race-fix branch May 10, 2022 13:17
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 10, 2022
@ehsandeep ehsandeep mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Fail - race-multiple
4 participants
@Ice3man543 @Mzack9999 @LuitelSamikshya @ehsandeep