Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed memory leak on hmap #3050

Closed
wants to merge 1 commit into from
Closed

Fixed memory leak on hmap #3050

wants to merge 1 commit into from

Conversation

vzamanillo
Copy link
Contributor

Proposed changes

Fixes #3043

#3043 (comment)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Initial 100 elements per target to initialize the filekv bloom filter…
3f575f5 
… for

dedup and fix a memory leak due to a excessive memory allocation
(MaxInt32)
@Mzack9999 Mzack9999 mentioned this pull request Dec 16, 2022
Merged
4 tasks
Mzack9999
Mzack9999 reviewed Dec 18, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially superseded by #3052

@vzamanillo
Copy link
Contributor Author

Yup, this can be closed.

@ehsandeep ehsandeep closed this Dec 19, 2022
@vzamanillo vzamanillo deleted the fix-fkv-memory-leak branch December 19, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vzamanillo @Mzack9999 @ehsandeep