Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown Reporting Index File #3129

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Markdown Reporting Index File #3129

merged 4 commits into from
Jan 15, 2023

Conversation

xm1k3
Copy link
Contributor

@xm1k3 xm1k3 commented Jan 2, 2023 •
edited
Loading

Proposed changes

image

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@xm1k3 xm1k3 self-assigned this Jan 2, 2023
@xm1k3 xm1k3 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 2, 2023
@xm1k3 xm1k3 linked an issue Jan 2, 2023 that may be closed by this pull request
Markdown Reporting Index File #2913
Closed
@xm1k3 xm1k3 requested a review from Mzack9999 January 3, 2023 13:48
Mzack9999
Mzack9999 requested changes Jan 3, 2023
View reviewed changes
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
@xm1k3
fixes on markdown generation
9d185aa 
added also hyperlink to markdown created
@xm1k3 xm1k3 requested a review from Mzack9999 January 4, 2023 14:43
Mzack9999
Mzack9999 requested changes Jan 4, 2023
View reviewed changes
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
v2/pkg/reporting/exporters/markdown/markdown.go Outdated Show resolved Hide resolved
@xm1k3 xm1k3 requested a review from Mzack9999 January 5, 2023 10:29
@ehsandeep ehsandeep requested a review from sullo January 7, 2023 13:04
@ehsandeep ehsandeep merged commit 84b0581 into dev Jan 15, 2023
@ehsandeep ehsandeep deleted the issue-2913-markdown-index branch January 15, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@sullo sullo Awaiting requested review from sullo

Assignees

@xm1k3 xm1k3

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown Reporting Index File
3 participants
@xm1k3 @ehsandeep @Mzack9999