Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving examples to go file #3187

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Moving examples to go file #3187

merged 1 commit into from
Jan 12, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 11, 2023 •
edited by xm1k3
Loading

Proposed changes

This PR moves the examples under v2/examples and compiles them as part of GH action.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jan 11, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 11, 2023
@Mzack9999 Mzack9999 changed the title moving examples to go file Moving examples to go file Jan 11, 2023
@Mzack9999 Mzack9999 linked an issue Jan 11, 2023 that may be closed by this pull request
Improving examples/use as a library docs #3096
Closed
2 tasks
@Mzack9999 Mzack9999 requested a review from xm1k3 January 11, 2023 15:34
xm1k3
xm1k3 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@xm1k3 xm1k3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ehsandeep ehsandeep merged commit 0b3992c into dev Jan 12, 2023
@ehsandeep ehsandeep deleted the issue-3096-examples branch January 12, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@xm1k3 xm1k3 xm1k3 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving examples/use as a library docs
3 participants
@Mzack9999 @ehsandeep @xm1k3