Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Argument Spelling #3536

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Apr 13, 2023

Proposed changes

While beginning work on another issue, the misspelling of "acccessKey" was identified.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works (N/A)
  • I have added necessary documentation (if appropriate) (N/A)

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

thanks for PR @kchason ,

FYI when we don't specify type of parameter in function . go by default assumes type of next parameter . hence

getS3Client(ctx context.Context, accessKey, secretKey, region string) == getS3Client(ctx context.Context, acccessKey string, secretKey string, region string)

@kchason
Copy link
Contributor Author

kchason commented Apr 13, 2023

Sounds good, I'm new to Go and didn't know that, thanks!

@ehsandeep ehsandeep merged commit 8ffbebb into projectdiscovery:dev Apr 13, 2023
@kchason kchason deleted the s3-argument-spelling branch April 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants