Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Reporting Checks #4107

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Aug 31, 2023

Proposed changes

In the createReportingOptions() function, when each exporter configuration struct is added, it checks to see if reportingOptions has been initialized, and then contains duplicated code after initializing it within the if statement.

This change changes the declaration at the top of the function to be an initialization and removes all checks later on in the function.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep merged commit bafde6c into projectdiscovery:dev Sep 18, 2023
12 checks passed
@ehsandeep ehsandeep removed the request for review from tarunKoyalwar September 18, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants