refactor(interactions): use the new channel field
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
added
type: enhancement
TTtie
force-pushed
the
feat/interaction-channel-field
branch
from
f4dee7a
to
31cb6cb
Compare
coolcalcacol
suggested changes
Apr 9, 2023
index.d.ts
Outdated
| @@ -69,6 +69,7 @@ declare namespace Dysnomia { | |||
| type GuildTextableChannel = TextChannel | TextVoiceChannel | NewsChannel | StageChannel; | |||
| type GuildTextableWithThreads = GuildTextableChannel | AnyThreadChannel; | |||
| type InviteChannel = InvitePartialChannel | Exclude<AnyGuildChannel, CategoryChannel | AnyThreadChannel>; | |||
| type PossiblyUncachedInteractionChannel = Textable | { id: string; type: ChannelTypes }; | |||
There was a problem hiding this comment.
Maybe use Pick<Channel, 'id' | 'type'>?
or use a new interface on line 63?
interface UncachedChannel extends Uncached { type: ChannelTypes }
There was a problem hiding this comment.
Textable also doesn't have any channel related properties, is there a better type we can use?
There was a problem hiding this comment.
Maybe TextableChannel | PartialChannel would be a better choice?
There was a problem hiding this comment.
Yeah, I agree.
Also, type in PartialChannel is a number instead of ChannelTypes. Something to update here?
There was a problem hiding this comment.
Definitely something to tackle (in a different PR)
TTtie
added a commit
that referenced
this pull request
Apr 14, 2023
* refactor(interactions): use the new `channel` field Ref: discord/discord-api-docs@88a7618 * use a better type for PossiblyUncachedInteractionChannel
TTtie
added a commit
that referenced
this pull request
May 11, 2023
* refactor(interactions): use the new `channel` field Ref: discord/discord-api-docs@88a7618 * use a better type for PossiblyUncachedInteractionChannel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: discord/discord-api-docs@88a7618