Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference tests need to be more fine-grained #21

Closed
Pike opened this issue Jun 16, 2020 · 0 comments · Fixed by #23
Closed

Reference tests need to be more fine-grained #21

Pike opened this issue Jun 16, 2020 · 0 comments · Fixed by #23
Assignees

Comments

@Pike
Copy link
Contributor

Pike commented Jun 16, 2020

Right now, reference tests just check the top level item type.

This made a couple of bugs slip through the cracks, we need to dive deeper into the comparison logic against the reference json.

I got some thoughts, taking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant