Fix syntax error in CI run #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
May 6, 2024
|
BTW, setting up to use the merge queue would have prevented that. |
|
@waywardmonkeys Yes, unfortunately I don't have access to all the repo settings and in particular the branch protection or CI requirements for PRs. I have in mind we probably should ask for it at some point, bit I also thought it might be best to roll with what we have for a little bit so folks can see we're making a good faith effort and are not on a path to making a bungling mess of things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #342 which didn't surface the error because actions don't run in PRs until they have been merged to the default branch