Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ES-257648; Ganglia deployment Docker image / layer #487

Closed
wants to merge 20 commits into from
Closed

Fix for ES-257648; Ganglia deployment Docker image / layer #487

wants to merge 20 commits into from

Conversation

a0x8o
Copy link
Collaborator

@a0x8o a0x8o commented Feb 16, 2022

What changes are proposed in this pull request?

Fix for Databricks ES-257648 for WSFS dir change issue on Databricks Container Services on Azure Databricks. Added dcs-wsfs.init, deployed to /databricks/scripts, to resolve.

Deployed Ganglia as its own image / layer to enable metrics collection and reporting on Databricks Container Services

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

Signed-off-by: a0x8o alex.barreto@databricks.com

@a0x8o
Copy link
Collaborator Author

a0x8o commented Feb 16, 2022

TBH this 'I must sign every commit' is overkill.

glow with ganglia; databricks-glow-minus-ganglia packages glow without
ganglia
with (and without) Ganglia; added emphases for suppirt level of Ganglia.
Copy link
Contributor

@williambrandler williambrandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments on making the language more concise

.metals/metals.log Outdated Show resolved Hide resolved
docker/databricks/build.sh Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
@williambrandler
Copy link
Contributor

williambrandler commented Feb 16, 2022

please bring your feature branch into line with master,

https://gist.github.com/whoisryosuke/36b3b41e738394170b9a7c230665e6b9

Also do not forget to --signoff any time you run the 'merge' command, otherwise commits won't pass DCO

Removed extraneous file in PR

Signed-off-by: Alex <alex.barreto@databricks.com>
Signed-off-by: Alex <alex.barreto@databricks.com>
@williambrandler
Copy link
Contributor

TBH this 'I must sign every commit' is overkill.

true, I can force merge it if this is the only test that fails

@a0x8o a0x8o closed this Feb 17, 2022
@a0x8o a0x8o deleted the ganglia branch February 17, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants