Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for GFF schema for Alias field #522

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

a-li
Copy link
Contributor

@a-li a-li commented Dec 22, 2022

What changes are proposed in this pull request?

Update documentation for GFF schema for Alias field

According to https://glow.readthedocs.io/en/latest/etl/gff.html#schema. Alias is defined as string. However, in the actual source code, it's defined as an array of string:

val aliasField = StructField("alias", ArrayType(StringType))

Updating the documentation so it is matching exactly how it's internally represented.

How is this patch tested?

  • Unit tests
  • Integration tests
  • Manual tests

(Details)

Signed-off-by: a-li <dzl@88665a545034.ant.amazon.com>
@a-li a-li force-pushed the sign-off-update-gff-schema-doc branch from 1a7f99f to 054af5d Compare December 22, 2022 01:12
@a0x8o a0x8o merged commit 1d6b3e6 into projectglow:master Jan 26, 2023
@a-li a-li deleted the sign-off-update-gff-schema-doc branch January 26, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants