Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ASM and JNA libraries #11

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Update ASM and JNA libraries #11

merged 2 commits into from
Jan 11, 2023

Conversation

mmoayyed
Copy link
Contributor

@mmoayyed mmoayyed commented Oct 6, 2022

Allows support for JDK 19 and 20. Please see https://asm.ow2.io/versions.html

Related: projectlombok/lombok#3264 and projectlombok/lombok#3251

@nolik
Copy link

nolik commented Nov 14, 2022

Is there any way to merge this patcher to unblock Java19 support?

@YassinHajaj
Copy link

Hello,
Any news on this ?

@Harmelodic
Copy link

Harmelodic commented Nov 21, 2022

Pinging @rzwitserloot @rspilker @Rawi01 @mmoayyed 👋 ❤️

Not sure which ones of you have write access, but this is blocking Lombok from supporting Java 19:
projectlombok/lombok#3264

Assuming there's no other issues, can this be merged ASAP?

@Rawi01
Copy link
Contributor

Rawi01 commented Nov 21, 2022

I have write access but there are some missing commits in this repository (#10) and merging this PR will most likely cause some issues. Even if I would ignore that the updated version needs to be published and thats impossible for me.

@rzwitserloot rzwitserloot merged commit 2c01357 into projectlombok:master Jan 11, 2023
@mmoayyed mmoayyed deleted the asm-update branch January 12, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants