Drop support for Python 3.8 #1756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
+ Coverage 79.87% 79.92% +0.04%
==========================================
Files 15 15
Lines 1267 1270 +3
Branches 277 277
==========================================
+ Hits 1012 1015 +3
Misses 216 216
Partials 39 39 ☔ View full report in Codecov by Sentry. |
|
I think this shouldn't be merged until after the CSSSA conference. We should instead release 2.1.2 with bugfix releases for the Solara viz. |
| @@ -60,7 +60,7 @@ | |||
| "source": [ | |||
| "### Tutorial Setup\n", | |||
| "\n", | |||
| "Create and activate a [virtual environment](http://docs.python-guide.org/en/latest/dev/virtualenvs/). *Python version 3.8 or higher is required*.\n", | |||
| "Create and activate a [virtual environment](http://docs.python-guide.org/en/latest/dev/virtualenvs/). *Python version 3.9 or higher is required*.\n", | |||
There was a problem hiding this comment.
Do we still want to do 3.9 as it seems Solara only works with 3.10 or higher?
There was a problem hiding this comment.
Quite the opposite, solara still supports Python 3.6. They are quite proud of it, although i cant find the source for that claim right now. But their unit tests still run on Python 3.6 https://github.com/widgetti/solara/blob/master/.github/workflows/unittest.yml
There was a problem hiding this comment.
Following SPEC 0, the successor of NEP 29, Python 3.9 can also be dropped at this point.
That would allow us to start using Structural Pattern Matching (also in examples) and use new typing features. See What’s New In Python 3.10.
Users still on Python 3.8 and 3.9 can of course still keep using the current Mesa versions, as always.
|
Will there be another patch release (2.1.6) after the current 2.1.5? If not, we could merge this right and release 2.2.0 in a bit. |
|
@rht could you please resolve the conflicts and then I will merge. Honestly, I am a little confused why it is saying these are conflicts |
|
Merge conflicts resolved. |
NumPy had dropped it since Jan 31 2023: https://numpy.org/neps/nep-0029-deprecation_policy.html.
If this PR is merged, the next release needs to be 2.2.0 instead of 2.1.2.