Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move codespell to pre-commit #2040

Merged
merged 3 commits into from
Feb 16, 2024
Merged

ci: Move codespell to pre-commit #2040

merged 3 commits into from
Feb 16, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Feb 16, 2024

Motivation: using pre-commit is faster than GH Actions.

@rht
Copy link
Contributor Author

rht commented Feb 16, 2024

Ready for review + merged. This PR should be squashed+merged.

@rht
Copy link
Contributor Author

rht commented Feb 16, 2024

I have confirmed that the pre-commit CI works, because I saw the commit

Intentionally introduce typos

failed, with the "allows" and "users" typo fix suggestions.

@quaquel
Copy link
Member

quaquel commented Feb 16, 2024

Looks good to me and good to know you have already tested it.

@EwoutH EwoutH added the ci Release notes label label Feb 16, 2024
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reduction of complexity!

@rht rht merged commit 0c35956 into projectmesa:main Feb 16, 2024
12 checks passed
@rht rht deleted the codespell branch February 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants