Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple connections #934

Closed
wants to merge 157 commits into from
Closed

Allow multiple connections #934

wants to merge 157 commits into from

Conversation

NeilW
Copy link

@NeilW NeilW commented Oct 25, 2020

This is the code fix.

Sorting the tests appears to be a bit of work - which I haven't got around to unfortunately.

rht and others added 30 commits January 16, 2020 12:58
clean html to attempt correct build
Corvince and others added 20 commits January 2, 2021 13:08
GA: Only run CI when pushed to master
forest_fire: Remove unnecessary code
Migrate away from type comments
…ame-columns

Fix order of variable_params in model and agent vars data frames
…ython-36

Fix asyncio on windows with python 3.6
@Corvince
Copy link
Contributor

After agreeing to merge this one in todays dev meeting, I tested it again and it seems not to work completely as expected.
While you can run multiple models in multiple tabs and they don't interrupt each other, as soon as you modify a parameter, that parameter is changed across all models, once they are reset.
To easily reproduce:

  1. Run Schelling example in Tab1
  2. Open in second Tab (Tab2)
  3. Decrease agent density in Tab 2
  4. Reset model in Tab 1, agent density will be lower

Can you confirm this @NeilW or am I doing something wrong?

NeilW and others added 6 commits February 11, 2021 22:54
Obtain the template directory from the module installation path
not the specific file - allowing you to have variations of the file
in your model if required
Add a '/healthz' path that returns 200 once the web server has
initialized. This allows loadbalancers and Kubernetes readiness checks
to succeed quickly on a known path.
This allows multiple tabs to be opened onto the same webserver, with
each tab running their own model.

Fixes projectmesa#856
Model instances were still sharing the same UserSettableParameters
Fixed by using a deep copy
@Corvince
Copy link
Contributor

Sorry I accidently killed this PR, I will reopen a truly working solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants