Gatling: properly prefer sim.duration.seconds over sim.commits
#5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
gatling-duration
branch
from
12b715a
to
0de262e
Compare
dimas-b
reviewed
Jan 17, 2023
The number of commits, if higher than 0, takes precedence over a configured duration, which requires manual setting of `-Dsim.commits=0` when using `sim.duration.seconds`, which is inconvenient.
snazy
force-pushed
the
gatling-duration
branch
from
0de262e
to
f4f3839
Compare
dimas-b
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of commits, if higher than 0, takes precedence over a configured duration, which requires manual setting of
-Dsim.commits=0when usingsim.duration.seconds, which is inconvenient.