-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename nessie-quarkus-cli to nessie-server-admin-tool #8482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the release CI workflows
Should we remove the |
nessie-server-admin-tool sounds fine |
b337e14
to
64d27ee
Compare
64d27ee
to
ff3ab12
Compare
site/in-dev/export_import.md
Outdated
@@ -15,26 +15,25 @@ such as: | |||
## Usage | |||
|
|||
The Nessie Quarkus CLI too requires direct access to the database used by Nessie. The executable is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph and the previous section both need some rephrasing. I also wonder if the page title shouldn't be changed to "Nessie Server Admin Tool".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. updated
Still find occurences of |
|
a382f17
to
5be3a7c
Compare
^ fixed, sorry about a lot of back-and-forth 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - except one must-revert/move
site/docs/downloads/index.md
Outdated
curl -o nessie-quarkus-cli-{{ versions.nessie }}-runner.jar \ | ||
https://github.com/projectnessie/nessie/releases/download/nessie-{{ versions.nessie }}/nessie-quarkus-cli-{{ versions.nessie }}-runner.jar | ||
java -jar nessie-quarkus-cli-{{ versions.nessie }}-runner.jar | ||
curl -o nessie-server-admin-tool-{{ versions.nessie }}-runner.jar \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change must also go into the follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already in #8484. I've removed this change from this PR.
Also move code under ./tools/server-admin This is a follow-up to projectnessie#8245 Closes projectnessie#8481
Took the freedom to fix the merge conflict and force-pushed |
Rename nessie-quarkus-cli to nessie-server-admin-tool
Also move code under ./tools/server-admin
This is a follow-up to #8245
Closes #8481