Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nessie-quarkus-cli to nessie-server-admin-tool #8482

Merged
merged 5 commits into from
May 11, 2024

Conversation

dimas-b
Copy link
Member

@dimas-b dimas-b commented May 8, 2024

Rename nessie-quarkus-cli to nessie-server-admin-tool

Also move code under ./tools/server-admin

This is a follow-up to #8245
Closes #8481

@dimas-b dimas-b requested review from adutra and snazy May 8, 2024 15:53
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the release CI workflows

helm/nessie/README.md Outdated Show resolved Hide resolved
site/docs/downloads/index.md Outdated Show resolved Hide resolved
site/docs/guides/migration.md Outdated Show resolved Hide resolved
site/docs/guides/migration.md Outdated Show resolved Hide resolved
site/in-dev/export_import.md Outdated Show resolved Hide resolved
@adutra
Copy link
Contributor

adutra commented May 8, 2024

Should we remove the -cli suffix? E.g. nessie-server-admin or nessie-admin-tool.

@snazy
Copy link
Member

snazy commented May 8, 2024

Should we remove the -cli suffix? E.g. nessie-server-admin or nessie-admin-tool.

nessie-server-admin-tool sounds fine

@dimas-b dimas-b changed the title Rename nessie-quarkus-cli to nessie-admin-cli Rename nessie-quarkus-cli to nessie-server-admin-tool May 8, 2024
@dimas-b dimas-b marked this pull request as ready for review May 8, 2024 21:16
@dimas-b dimas-b requested a review from snazy May 8, 2024 21:16
@@ -15,26 +15,25 @@ such as:
## Usage

The Nessie Quarkus CLI too requires direct access to the database used by Nessie. The executable is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph and the previous section both need some rephrasing. I also wonder if the page title shouldn't be changed to "Nessie Server Admin Tool".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. updated

@snazy
Copy link
Member

snazy commented May 10, 2024

Need to update the release CI workflows

Still find occurences of nessie-quarkus-cli in release-publish.yml, which will break releases

@dimas-b
Copy link
Member Author

dimas-b commented May 10, 2024

rg does not look into hidden dirs 🤦

@dimas-b
Copy link
Member Author

dimas-b commented May 10, 2024

^ fixed, sorry about a lot of back-and-forth 🤦

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except one must-revert/move

curl -o nessie-quarkus-cli-{{ versions.nessie }}-runner.jar \
https://github.com/projectnessie/nessie/releases/download/nessie-{{ versions.nessie }}/nessie-quarkus-cli-{{ versions.nessie }}-runner.jar
java -jar nessie-quarkus-cli-{{ versions.nessie }}-runner.jar
curl -o nessie-server-admin-tool-{{ versions.nessie }}-runner.jar \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change must also go into the follow-up PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in #8484. I've removed this change from this PR.

@snazy
Copy link
Member

snazy commented May 11, 2024

Took the freedom to fix the merge conflict and force-pushed

@snazy snazy merged commit becdd27 into projectnessie:main May 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename nessie-quarkus-cli
3 participants