Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license reports and checks #8497

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

snazy
Copy link
Member

@snazy snazy commented May 10, 2024

Dependencies, runtime dependencies including those that are distributed as part of a fat/uber jar, must use a "compatible" license. Checking those licenses manually is good, but some automatic checks are better.

This change adds a Gradle plugin to check licenses in the runtime configurations of the Nessie distributables (see below), and to produce license reports as HTML.

Nessie distributable are:

  • Nessie Quarkus Server
  • Nessie Quarkus CLI
  • Nessie GC tool
  • Nessie Content Generator
  • Nessie Spark SQL extensions
  • Nessie CLI/REPL

Checks and reports are run against the runtimeClasspath configurations of the above.

Dependencies, runtime dependencies including those that are distributed as part of a fat/uber jar, must use a "compatible" license. Checking those licenses manually is good, but some automatic checks are better.

This change adds a Gradle plugin to check licenses in the runtime configurations of the Nessie distributables (see below), and to produce license reports as HTML.

Nessie distributable are:
* Nessie Quarkus Server
* Nessie Quarkus CLI
* Nessie GC tool
* Nessie Content Generator
* Nessie Spark SQL extensions
* Nessie CLI/REPL

Checks and reports are run against the `runtimeClasspath` configurations of the above.
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Would you like in-depth reviews on gradle/license/allowed-licenses.json or is it somehow pre-validated?

@snazy
Copy link
Member Author

snazy commented May 10, 2024

Would you like in-depth reviews on gradle/license/allowed-licenses.json or is it somehow pre-validated?

A second pair of eyes looking into that would be good. It's been a while since (June last year) I originally built this change (forgot to open a PR).

@snazy snazy merged commit 582742c into projectnessie:main May 11, 2024
16 checks passed
@snazy snazy deleted the license-report-plugin branch May 11, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants