Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubi9/openjdk-21-runtime instead of ubi9/openjdk-21 as the base image #8503

Merged
merged 1 commit into from
May 11, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented May 11, 2024

Supersedes #8502

Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – is this worth a mention in the changelog?

@@ -20,7 +20,7 @@
# (See site/docs/try/configuration.md)
#
###
FROM registry.access.redhat.com/ubi9/openjdk-21:1.18-4
FROM registry.access.redhat.com/ubi9/openjdk-21-runtime:1.18-4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing a docker build & docker save I observed that the total uncompressed image size went down from 682 MiB to 584 MiB. Nice!

I also validated that the JAVA_OPTS_APPEND,JAVA_TOOL_OPTIONS and JAVA_DEBUG env vars are still working.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observed that the total uncompressed image size went down from 682 MiB to 584 MiB. Nice!

Not so much on for amd64 - "just" down by 40MB - but still.

@snazy
Copy link
Member Author

snazy commented May 11, 2024

is this worth a mention in the changelog?

Don't think so - it's the same base image, just without the Java tools.

@snazy snazy merged commit fbd5efb into projectnessie:main May 11, 2024
16 checks passed
@snazy snazy deleted the use-runtime-base-image branch May 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants