Nessie client: optionally disable certificate verifications #8506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
reviewed
May 13, 2024
api/client/src/main/java/org/projectnessie/client/http/HttpClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
Disabling cerficate verfications is strongly not recommended for production use. It shall only be used for testing purposes.
snazy
force-pushed
the
client-ssl-no-verify
branch
from
04c7519
to
35886b5
Compare
dimas-b
reviewed
May 13, 2024
api/client/src/main/java/org/projectnessie/client/NessieClientBuilder.java
Outdated
Show resolved
Hide resolved
adutra
reviewed
May 13, 2024
api/client/src/main/java/org/projectnessie/client/http/HttpClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
adutra
approved these changes
May 13, 2024
dimas-b
reviewed
May 13, 2024
| @@ -129,6 +139,12 @@ public HttpClient.Builder setResponseFactory(HttpResponseFactory responseFactory | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public HttpClient.Builder setSslNoCertificateVerification(boolean noCertificateVerification) { | |||
There was a problem hiding this comment.
Maybe setSSLCertificateVerificationDisabled here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling cerficate verfications is strongly not recommended for production use. It shall only be used for testing purposes.