This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Make the service name used by a core deployer configurable #200
Comments
Good idea, i like it. Was there a reason not to use the deployer name as the default service name? |
Example with proposed CLI flag If flag is not provided, the current (auto-generated) name is used. |
glyn
added a commit
to glyn/system
that referenced
this issue
Nov 29, 2019
glyn
added a commit
that referenced
this issue
Nov 29, 2019
@scothis is questioning this approach - re-opening for further discussion. |
glyn
added a commit
to glyn/system
that referenced
this issue
Dec 3, 2019
This reverts commit 09c4793. Closes projectriff#200
This was referenced Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the deployers generate a service name to keep them unique. This makes it harder to discover services since you can't bind using just the DNS name, you would have to look it up based on labels. We should provide a way to define the actual name used and the end-user would be responsible for avoiding clashes. If user doesn't specify the name, then we should generate one as we do today.
The text was updated successfully, but these errors were encountered: