Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Make the service name used by a core deployer configurable #214

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

glyn
Copy link
Contributor

@glyn glyn commented Nov 29, 2019

Fixes #200

@codecov-io
Copy link

Codecov Report

Merging #214 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #214      +/-   ##
=========================================
- Coverage    8.67%   8.66%   -0.01%     
=========================================
  Files          61      61              
  Lines        4151    4154       +3     
=========================================
  Hits          360     360              
- Misses       3758    3761       +3     
  Partials       33      33
Impacted Files Coverage Δ
pkg/apis/core/v1alpha1/deployer_types.go 33.33% <ø> (ø) ⬆️
pkg/controllers/core/deployer_controller.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0489b50...6127438. Read the comment docs.

@fbiville fbiville self-assigned this Nov 29, 2019
@fbiville fbiville self-requested a review November 29, 2019 14:18
@fbiville fbiville removed their assignment Nov 29, 2019
@glyn glyn merged commit 09c4793 into projectriff:master Nov 29, 2019
Copy link
Member

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few cases that need to be handled before this can be merged:

  • what if there is an existing service with that name?
  • what if the serviceName is set on an existing deployer
  • what if the serviceName is removed from an existing deployer

@jldec jldec changed the title Make the service name used by the deployer configurable Make the service name used by a core deployer configurable Nov 29, 2019
@glyn glyn deleted the 200-service-name branch November 29, 2019 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the service name used by a core deployer configurable
4 participants