changed port array to store based on id #725
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn run pretty
What?
In reference to #724 I think it is unwise to store ports based on a user provided name, as this can easily create clashes. The unique ID is a less opinionated choice
Why?
Well, personally I think I lost a couple hairs on my head because of this, hopefully this will prevent future hair loss :D
How?
Changed
addPort
and a couple other methods to store/pull ports based on ID instead of nameFeel good image: