Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all facts available as parameters.facts #192

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Make all facts available as parameters.facts #192

merged 3 commits into from
Sep 25, 2020

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Sep 24, 2020 •
edited
Loading

Resolves #98

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@corvus-ch corvus-ch self-assigned this Sep 24, 2020
@corvus-ch corvus-ch marked this pull request as ready for review September 24, 2020 15:15
simu
simu approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a quick grep over the docs shows no need for adjustment.

CHANGELOG.md Outdated Show resolved Hide resolved
srueg
srueg suggested changes Sep 25, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@corvus-ch corvus-ch merged commit 11049d4 into master Sep 25, 2020
@corvus-ch corvus-ch deleted the facts branch September 25, 2020 07:42
This was referenced Sep 25, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@megian megian mentioned this pull request Sep 29, 2020
Merged
3 tasks
@srueg srueg mentioned this pull request Oct 9, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

@srueg srueg srueg approved these changes

Assignees

@corvus-ch corvus-ch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide All Cluster Facts in Target
3 participants
@corvus-ch @simu @srueg