Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Ratio Observations values to null instead of 0 #263

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

dczulada
Copy link
Contributor

@dczulada dczulada commented Jun 28, 2024

This is related to

https://oncprojectracking.healthit.gov/support/browse/CYPRESS-2669

The following is from HQMF

2.3.1.3.1Individual Observations
For each case in the DENOM and not in the DENEX, determine the individual DENOM observations.
For each case in the NUMER and not in the NUMEX, determine the individual NUMER observations.

2.3.1.3.2Measusre Aggregates
Using individual observations for all cases in the DENOM and not in the DENEX, calculate the aggregate DENOM.
Using individual observations for all cases in the NUMER and not in the NUMEX, calculate the aggregate NUMER.

Ratio = aggregate NUMER / aggregate DENOM

Pull requests into cqm-execution require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.

Submitter:

  • This pull request describes why these changes were made.
  • Internal ticket for this PR:
  • Internal ticket links to this PR
  • Code diff has been done and been reviewed
  • Tests are included and test edge cases
  • Tests have been run locally and pass

Reviewer 1:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@dczulada dczulada marked this pull request as ready for review July 10, 2024 15:05
adongare
adongare previously approved these changes Jul 11, 2024
@dczulada
Copy link
Contributor Author

@adongare I just did a rebase on the most recent master commits. Looks like you might need to approve the PR again.

@dczulada dczulada merged commit 5341fb0 into master Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants