Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statement name and library name info to HTML output for each define statement #250

Merged
merged 1 commit into from
May 30, 2023

Conversation

hossenlopp
Copy link
Contributor

@hossenlopp hossenlopp commented May 26, 2023

Summary

Adds the libraryName and statementName as extra data in the HTML output.

New behavior

Info is added to the <pre> tag for each define statement as data-library-name and data-statement-name attributes.
Example:

<pre data-library-name="DiabetesHemoglobinA1cHbA1cPoorControl9FHIR" data-statement-name="Initial Population">

Code changes

HTMLBuilder.ts - Adds statementName to the data collected and sent to the handlebars template.
main.ts - Adds the data- attributes to the <pre> tag for the statement.

Testing guidance

Run unit tests.

Run calculation that outputs HTML. Detailed results with debug output would work. Look in HTML output for the data attributes in the <pre> tags. Spot check that they are identifying the statement name correctly for the statement content.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.44% 2218/2566
🟡 Branches 75.25% 2037/2707
🟢 Functions 89.32% 410/459
🟢 Lines 86.78% 2140/2466

Test suite run success

411 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from 833fbb6

@hossenlopp hossenlopp changed the title tatement name and library name data to HTML output for each st… Statement name and library name info to HTML output for each define statement May 26, 2023
@mgramigna mgramigna self-requested a review May 30, 2023 12:13
@mgramigna mgramigna self-assigned this May 30, 2023
Copy link
Contributor

@mgramigna mgramigna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@natjoe4 natjoe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@natjoe4 natjoe4 merged commit c66d676 into master May 30, 2023
@natjoe4 natjoe4 deleted the statement-html-data-attrs branch May 30, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants