Fix ValueSet reference finder to use proper resource field in relatedArtifacts #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success449 tests passing in 31 suites. Report generated by 🧪jest coverage report action from 8f9621d |
elsaperelli
approved these changes
Oct 18, 2023
hossenlopp
force-pushed
the
fix-valueset-ref-finding
branch
from
edc9d91
to
6333ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks for the ValueSet references in the RelatedArtifact
resourcefield. Previously this only looked for the references in the non-existenturlfield which many measures were using.New behavior
Looks at
resourcein addition tourlwhen looking for referenced ValueSet URLsCode changes
ValueSetHelper.ts- Looks inresourceas well.Testing guidance
Run unit tests.
Add ValueSets to a recent measure package that has the fixed references, ensure ValueSets that are referenced in
relatedArtifactsonly are being pulled in. For example:http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1029.206for the Intensive Care Unit location is not something that will be in thedataRequirementsand is only in therelatedArtifactsin CMS190.