fix zstd decompressor since initrd has no content size header #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 84.42% 84.42%
=======================================
Files 16 16
Lines 745 745
=======================================
Hits 629 629
Misses 116 116
Continue to review full report at Codecov.
|
mgorny
reviewed
Nov 3, 2020
ecleankernel/file.py
Outdated
| @@ -123,7 +123,8 @@ def decompress_raw(self) -> bytes: | |||
| # Technically a redundant import, this is just | |||
| # to make your IDE happy :) | |||
| import zstandard | |||
| return zstandard.ZstdDecompressor().decompress(f.read()) | |||
| return zstandard.ZstdDecompressor().decompress( | |||
| f.read(), 200*1024*1024) | |||
|
yes, yes it is - somehow managed to pick the wrong commit, don't rebase at night! |
mgorny
reviewed
Aug 10, 2021
Signed-off-by: Jannik Glückert <jannik.glueckert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the kernel image and/or initrd may not include content size when compressed with zstd - switch to the zstd stream reader and read in chunks of 1MB until EOF
See the section above https://pypi.org/project/zstandard/ - Stream Reader API for details