Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept role list as string value #60

Closed
wants to merge 1 commit into from
Closed

Conversation

bskiefer
Copy link

Allows processing the role with the following response:

<Attribute Name="https://aws.amazon.com/SAML/Attributes/Role">
	<AttributeValue>arn:aws:iam::ID:role/RoleName,arn:aws:iam::ID:saml-provider/WAAD</AttributeValue>
</Attribute>

@prolane
Copy link
Owner

prolane commented Dec 16, 2022

Hi @bskiefer , I've just published v3.1 as a fix for #58. This includes a few small changes which are related to your PR.

alwaysCreateTextNode: true

else if (attributes_role_list.hasOwnProperty('#text')) {

In my own IDP setup, I actually have a test scenario containing the same format of SAML Assertion AttributeValue as you posted here. On my end this is processed correctly. Therefore, at this moment I don't see the need for this PR.

Please wait for Google to release v3.1, hopefully somewhere tomorrow. Give it a try and let me know if this fixed the issue for you. If not, please reopen the PR and provide me with the debug logs from the extension.

Cheers mate.

@prolane prolane closed this Dec 16, 2022
@bskiefer
Copy link
Author

3.2 seems to be worked as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants