-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json rpc server returns trace if enabled #60
Conversation
This change does not match the JSON-RPC 2.0 Spec for the error object. Maybe the trace should be in |
The trace is only meant for debugging in development mode, and should not be turned on in production, that's why I think it's okay to add it as additional field to the error object. The purpose of data is to show example data, how a good request looks like, also changing the data field would lead to BC break on consumer side, that's why we should not add it to data. |
http://www.jsonrpc.org/specification#error_object
The data field is defined exactly for this behaivor.. adding some more info about the error. |
see also: #56
This is a small BC as the Error Interface now has an additional method. Usually it would not be expected to have an implementation of this Error Interface in userland code, so maybe we can introduce it without new major version.
Thoughts? @oqq @thomasvargiu @bweston92