Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional arguments when providing full namespaced paths #25

Closed
paales opened this issue Mar 11, 2018 · 2 comments
Closed

Optional arguments when providing full namespaced paths #25

paales opened this issue Mar 11, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@paales
Copy link
Contributor

paales commented Mar 11, 2018

namespace ReachDigital\Subscription\Model\ProductPlan\Command {
    data SubmitFormWebsiteScope = SubmitFormWebsiteScope {
        \ReachDigital\Subscription\Model\ProductPlan\PlanId $planId,
        \ReachDigital\Subscription\Model\ProductPlan\WebsiteId $websiteId,
        ?\ReachDigital\Subscription\Model\ProductPlan\Enabled $enabled,
        ?\ReachDigital\Subscription\Model\ProductPlan\EnabledOnFrontend $enabledOnFrontend,
        ?\ReachDigital\Subscription\Model\ProductPlan\InitialPrice $initialPrice,
        ?\ReachDigital\Subscription\Model\ProductPlan\InstallmentPrice $installmentPrice,
    } deriving (Command);
}

Will thow an error:
Parse Error: Syntax error, unexpected '\', expecting 'T_STRING' at line 59 on file

Also it seems there is an off-by-one error in the error reporting, it actually should be line 58 in my case.

@prolic prolic closed this as completed in 3df0bdb Mar 11, 2018
@prolic
Copy link
Owner

prolic commented Mar 11, 2018

This is fixed now, I don't know about the line number issue though, I'll create another issue for this and see what I can do when I have some little extra time, not important right now.

@prolic prolic added the bug Something isn't working label Mar 11, 2018
@paales
Copy link
Contributor Author

paales commented Mar 11, 2018

Agreed, not important right now :)

Adirelle pushed a commit to Adirelle/fpp that referenced this issue Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants