Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use separate components of Caishen #70

Merged
merged 3 commits into from
Jul 11, 2016

Conversation

DannyVancura
Copy link
Contributor

  • Changed access level of Card.init, Expiry.invalid, CVCInputTextField.cardType and DetailInputTextField.cardIntoTextFieldDelegate in order to make them accessible when using these properties outside of Caishen.
  • Added section in Readme that shows a (very basic) example of how to implement the different components of Caishen

This closes #68

### Using the different components of the text field separately

Instead of entering the card number, expiry and CVC in a single text field, it is possible to use single text fields to enter this information separately.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section go at the end? Is it more important than cardio or custom card types?

@mohammad19991
Copy link

mohammad19991 commented May 31, 2016

@DannyVancura you should also change UnknownCardType access level to public like the other types.
and I created another example the components works fine so fare 👍

* Changed access level of `Card.init`, `Expiry.invalid`, `CVCInputTextField.cardType` and `DetailInputTextField.cardIntoTextFieldDelegate` in order to make them accessible when using these properties outside of Caishen.
* Added section in Readme that shows a (very basic) example of how to implement the different components of Caishen

This closes #68
@DannyVancura DannyVancura merged commit 715cadf into master Jul 11, 2016
@DannyVancura DannyVancura deleted the feature/separate_text_fields branch July 11, 2016 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it possible to use Caishen components separately
3 participants