-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove unnecessary dependency on jmespath #22
Conversation
6f40a02
to
fd2cb94
Compare
CC @gardar |
Looks like the lint issue is unrelated. Looking into it. |
Nice catch, LGTM! |
@flowerysong please rebase |
77c6d84
to
1779fdb
Compare
Test failures look unrelated. Tests against Ansible 2.9 are failing because Ansible 2.9 reached EOL last May and is missing many collection features (like support for git dependencies in requirements.yml.) The 2.12 failure was API rate limiting:
|
Actually, the 2.9 failure is because we started fetching things from git instead of galaxy. The old version does not support fetching from git. |
That's what I said. There's a decent chance that my change will also legitimately fail on 2.9; automatic generator unrolling wasn't added until 2.10. I think |
This is fairly straightforward manipulation to do with standard Jinja features. Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
1779fdb
to
89ec2ce
Compare
2.9 test has been fixed by #37 |
This is straightforward manipulation to do with standard Jinja features, there's no need to use a non-default library.