New unit value 64kB #740
Merged
New unit value 64kB #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Mysyura <olexandr.mysyura@pragmaticplay.com>
|
Fixes #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Postgres 15 database, exporter panic with error:
`panic: Unknown unit for runtime variable: "64kB"
goroutine 25 [running]:
main.(*pgSetting).metric(0xc0005790e0, 0xc0003b9c50?)
/app/cmd/postgres_exporter/pg_setting.go:87 +0x2fc
main.querySettings(0x0?, 0xc0001b4fd0)
/app/cmd/postgres_exporter/pg_setting.go:56 +0x29e
main.(*Server).Scrape(0xc0001b4fd0, 0xc000026011?, 0xd0?)
/app/cmd/postgres_exporter/server.go:121 +0xd7
main.(*Exporter).scrapeDSN(0xc0001bc0c0, 0xc0000ce764?, {0xc000026011, 0x55})
/app/cmd/postgres_exporter/datasource.go:116 +0x1cd
main.(*Exporter).scrape(0xc0001bc0c0, 0xc0000ce660?)
/app/cmd/postgres_exporter/postgres_exporter.go:711 +0x235
main.(*Exporter).Collect(0xc0001bc0c0, 0xc0000ce760?)
/app/cmd/postgres_exporter/postgres_exporter.go:600 +0x27
github.com/prometheus/client_golang/prometheus.(*Registry).Gather.func1()
/go/pkg/mod/github.com/prometheus/client_golang@v1.12.2/prometheus/registry.go:448 +0x11a
created by github.com/prometheus/client_golang/prometheus.(*Registry).Gather
/go/pkg/mod/github.com/prometheus/client_golang@v1.12.2/prometheus/registry.go:538 +0xb0b
`
So, MR only add a new unit - 64kB