Add feature to filter project ID at call-time #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xairos
force-pushed
the
project-id-filtering-feature
branch
from
6f80a05
to
a5673c9
Compare
|
This needs a rebase. |
Signed-off-by: Ben Rottke <benjaminr@ecobee.com>
Signed-off-by: Ben Rottke <benjaminr@ecobee.com>
xairos
force-pushed
the
project-id-filtering-feature
branch
from
a5673c9
to
12b1048
Compare
SuperQ
approved these changes
Mar 11, 2024
xairos
added a commit
to xairos/stackdriver_exporter
that referenced
this pull request
Mar 13, 2024
…munity#164)" This reverts commit bc18b73. Signed-off-by: Ben Rottke <benjaminr@ecobee.com>
SuperQ
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @SuperQ ! This is an implementation of the feature proposal in #145, TLDR to allow filtering by project ID at scrape-time. Our use case is multi-tenancy, where each tenant can scrape a centrally hosted SD exporter with their own project IDs as scrape parameters.
Closes #145.
Breaking changes
Call-time filtering via the
collectparameter now also matches if any preconfigured metric prefix is a string prefix for the call-time filter.Example
Running stackdriver exporter with the prefix
dataflow.googleapis.com/job/would allow you to use the following collect config: