Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions about systemd-resolved option #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

egmc
Copy link
Contributor

@egmc egmc commented Jan 12, 2024

Since #119 has been merged, add descriptions for this feature and new flag.

Signed-off-by: egmc <waltz4debby@eg2mix.com>
@egmc
Copy link
Contributor Author

egmc commented Jan 13, 2024

I tried to follow current manner to write all metrics and expected cardinality for each metrics.
Though it could be a bit burden for future documentation, and these information(metrics type, cardinality) is not important as users can retrieve it from metrics itself.

So may be we should keep this level's documentation only for core systemd metrics, and less description about additional collector would be there(e.g. add more section like Additional Collectors and add one line systemd_resolved: per exporter metrics with prefix sytemd_resolved .

@egmc
Copy link
Contributor Author

egmc commented Jan 15, 2024

@SuperQ
Hi, I think at least I need to add a description about new flag option for future release.
Should I fix the conflict and keep metrics description like watchdog metrics for now?
I'm going to fix it if needed.

@egmc egmc mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant