Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alert indexing and search #1202

Open
gouthamve opened this issue Jan 16, 2018 · 3 comments
Open

Improve alert indexing and search #1202

gouthamve opened this issue Jan 16, 2018 · 3 comments

Comments

@gouthamve
Copy link
Member

gouthamve commented Jan 16, 2018

From @brancz

currently there are various maps to improve access to certain alerts, but very scattered across the code base and seemingly unrelated

Further, I remember discussion of using the TSDB inverted index to do this.

@brancz
Copy link
Member

brancz commented Jan 16, 2018

Questionable whether we should use it 1 to 1 or just as a concept, but yes I think the concept of the inverted index would work nicely, there are other questions of how to populate it efficiently and remove alerts efficiently as well though as don't have the same expectations as TSDB in terms of "immutability" of historic data.

@sipian
Copy link
Contributor

sipian commented Mar 16, 2018

#GSOC-2018
I would like to take this issue up. Could someone elaborate a bit more on the problem at hand.

@brancz
Copy link
Member

brancz commented Mar 19, 2018

The problem is that Alertmanager currently holds the alerts ingested simply in a map, and when the frontend or anything using the API wants to filter something, then Alertmanager filters them naively in the HTTP handlers, whereas we should be able to index the alerts more precisely in order to not have to iterate over the entire set of alerts currently in memory.

hh pushed a commit to ii/alertmanager that referenced this issue Dec 20, 2018
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants