Update x/sys and x/net modules to support Risc-V #1984
Conversation
There was a problem hiding this comment.
Interesting. This looks good to me, but I will leave this open for @simonpasquier as he has also been involved in prometheus/prometheus#5621.
Thanks @carlosedp.
go.mod
Outdated
| golang.org/x/net v0.0.0-20181201002055-351d144fa1fc | ||
| golang.org/x/text v0.3.1-0.20180805044716-cb6730876b98 // indirect | ||
| golang.org/x/tools v0.0.0-20190118193359-16909d206f00 | ||
| golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect |
There was a problem hiding this comment.
From github.com/miekg/dns, this repository hasn't yet moved to Go modules but it's in progress (miekg/dns#980).
go.mod
Outdated
| golang.org/x/tools v0.0.0-20190118193359-16909d206f00 | ||
| golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect | ||
| golang.org/x/net v0.0.0-20190724013045-ca1201d0de80 | ||
| golang.org/x/sys v0.0.0-20190801041406-cbf593c0f2f3 // indirect |
There was a problem hiding this comment.
From github.com/prometheus/client_golang/prometheus which is already enabled for Go modules.
go.mod
Outdated
| golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 // indirect | ||
| golang.org/x/net v0.0.0-20190724013045-ca1201d0de80 | ||
| golang.org/x/sys v0.0.0-20190801041406-cbf593c0f2f3 // indirect | ||
| golang.org/x/text v0.3.2 // indirect |
There was a problem hiding this comment.
From github.com/PuerkitoBio/purell (via github.com/go-openapi/spec) which isn't Go modules ready.
|
@simonpasquier actually the bump only added an indirect reference to x/sys. The tools and crypto were already there. |
|
Ping @simonpasquier |
|
Hey @simonpasquier , can I rebase this PR? |
|
@carlosedp go ahead! |
|
@simonpasquier done! Some weird error on test_frontend... |
|
Yes see #2013, you'll need to rebase after it merges. |
|
Ah, ok. I'll wait till it's merged. |
|
It's merged 😏 |
|
I've rebased but still errors.... |
Signed-off-by: CarlosEDP <me@carlosedp.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
It was a CI glitch. I've removed the |
|
Thanks! |
|
Thanks for the merge and sorry about the 1.13 directive! |
Updating projects using libraries that were recently updated to support Risc-V architecture.
Go upstream work is tracked on: golang/go#27532
Risc-V software support tracker on https://github.com/carlosedp/riscv-bringup
Signed-off-by: CarlosEDP me@carlosedp.com