CI: Pin the mixtool version in CircleCI and update the golang CircleCI orb #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mixtool, the tip of master broke for our mixin - I have managed to trace it down and opened a PR (see grafana/dashboard-linter#143) but for now, let's pin the version to make sure our CI is not affected. Signed-off-by: gotjosh <josue.abreu@gmail.com>
|
This one at least fixes 1 of the 2 failures - I'd say let's merge this one and tackle the other one independently. |
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
changed the title
gotjosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mixtool, the tip of master broke for our mixin - I have managed to trace it down and opened a PR (see grafana/dashboard-linter#143) but for now, let's pin the version to make sure our CI is not affected.
There's also the fact that I golang circleCI orb hasn't been updated in ages - updating it solved the CI problem we hand on tests_frontend where the goland version was failing to install. I think this might have been a result of #3411