Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GC and callback from store.go #3840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove GC and callback from store.go #3840

wants to merge 1 commit into from

Commits on May 26, 2024

  1. Remove GC and callback from store.go 

    This commit removes the GC and callback function from store.go
to address a number of data races that have occurred in the past
(prometheus#2040 and prometheus#3648). The store is no longer responsible for removing
resolved alerts after some elapsed period of time, and is instead
deferred to the consumer of the store (as done in prometheus#2040 and prometheus#3648).

Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b9ee89e View commit details
    Browse the repository at this point in the history